cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aleksey Yeschenko (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-6895) ArrayBackedSortedColumns removeInternal should update sortedsize
Date Thu, 20 Mar 2014 15:08:48 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-6895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13941815#comment-13941815
] 

Aleksey Yeschenko edited comment on CASSANDRA-6895 at 3/20/14 3:08 PM:
-----------------------------------------------------------------------

The reason is symmetry with internalAdd - it also doesn't update the sorted size, because
sometimes it can and sometimes it can't be done.

Both methods are private, you can't call them anyway (both internalAdd and internalRemove),
so I don't see how this changes anything whatsoever for you.

Please don't reopen again.


was (Author: iamaleksey):
The reason is symmetry with internalAdd - it also doesn't update the sorted size, because
sometimes it can and sometimes it can't be done.

Both methods are private, you can call them anyway (both internalAdd and internalRemove),
so I don't see how this changes anything whatsoever for you.

Please don't reopen again.

> ArrayBackedSortedColumns removeInternal should update sortedsize
> ----------------------------------------------------------------
>
>                 Key: CASSANDRA-6895
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6895
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Edward Capriolo
>            Assignee: Edward Capriolo
>            Priority: Minor
>
> I was trying to use ArrayBackedblabla directly and I noticed that while internalAdd updates
the sorted size internal remove does not.
> https://github.com/edwardcapriolo/cassandra/compare/ArrayBackBackToCali?expand=1



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message