cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Anastasyev (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-6863) Incorrect read repair of range thombstones
Date Mon, 17 Mar 2014 14:59:46 GMT


Oleg Anastasyev commented on CASSANDRA-6863:

By the way, should not ColumnFamily.digest include range thombstones, so entropy in range
thombstones is detected and read repaired ? Currently only cells and deleted cells are participate
in digest response calculation as I can see in ColumnFamily.digest() and ReadVerbHandler.getResponse...

> Incorrect read repair of range thombstones
> ------------------------------------------
>                 Key: CASSANDRA-6863
>                 URL:
>             Project: Cassandra
>          Issue Type: Bug
>         Environment: 2.0
>            Reporter: Oleg Anastasyev
>         Attachments: ReadRepairRangeThombstoneDiff.txt, ReadRepairsDebugLogger.txt
> Rows with range thombstones are read repaired for every replica, if RR is triggered (this
is because CF.diff() returns non null if !isEmpty(), which in turn returns false if range
thombstones list is not empty). 
> Also, full rangethombstone list is send to all nodes, which could be a problem if you
have wide partition.
> Fixed this by evaluating diff on range thombstone lists as well as on deteleInfo of endpoint
CF versions. Also return null from CF.diff, if no diff in RTL.
> A second patch (ReadRepairsDebugLogger.txt) adds some debug logging to look at read repairs.
You may find it useful as well.

This message was sent by Atlassian JIRA

View raw message