cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vijay (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-6814) We should ensure that AbstractReadExecutor.makeDigestRequests never calls the local machine
Date Mon, 17 Mar 2014 17:49:43 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-6814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13938097#comment-13938097
] 

Vijay edited comment on CASSANDRA-6814 at 3/17/14 5:47 PM:
-----------------------------------------------------------

Attached is a simple patch which moves the localhost comparison (priority) to AbstractEndpointSnitch.sortByProximity
so the dynamic snitch will not overwrite comparing the scores. 

cc [~brandon.williams]

The motivation for this change is to avoid another sort, let me know if this works. My tests
shows the assertion added doesn't break.


was (Author: vijay2win@yahoo.com):
Attached is a simple patch which moves the localhost comparison (priority) to AbstractEndpointSnitch.sortByProximity
so the dynamic snitch will not overwrite comparing the scores. 

The motivation for this change is to avoid another sort, let me know if this works. My tests
shows the assertion added doesn't break.

> We should ensure that AbstractReadExecutor.makeDigestRequests never calls the local machine
> -------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-6814
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6814
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Benedict
>            Assignee: Vijay
>            Priority: Minor
>             Fix For: 3.0
>
>         Attachments: 0001-CASSANDRA-6814.patch
>
>
> It should always opt to perform the actual read locally, when possible, and this code
path should assert that it does not read locally.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message