cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joshua McKenzie (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-4050) Unable to remove snapshot files on Windows while original sstables are live
Date Mon, 31 Mar 2014 17:51:18 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13955439#comment-13955439
] 

Joshua McKenzie commented on CASSANDRA-4050:
--------------------------------------------

Good catch on getPosition - I accounted for that in current() but that hadn't triggered on
any testing and was an oversight.

I kept AbstractDataInput and AbstractDataInputSmall separate in the type heirarchy because
I didn't want to push the int -> long signature change down to all the classes that implemented
the base.  I'm not sure if the added footprint justifies the added complexity or not - I was
trying to minimize changes to unrelated classes due to the loss of RAF code.  I didn't like
it, but I also don'e like the alternative that much.  It looks like we run the risk of Bad
Things if someone does a MemoryInputStream.skipBytes that pushes the position past Max Int
- this impl has us casting off the remainder on a seek call so you could end up in negative
territory.

As for the tidying up - looks good to me.  Thanks for taking the time to do that - clean idiomatic
usage of the nio API's clearly makes things easier to parse.

Tests on linux look good, snapshots on Windows behave w/benedict's revisions and no mmap,
and read performance looks comparable so I +1 the changes with the above caveat.

> Unable to remove snapshot files on Windows while original sstables are live
> ---------------------------------------------------------------------------
>
>                 Key: CASSANDRA-4050
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4050
>             Project: Cassandra
>          Issue Type: Bug
>         Environment: Windows 7
>            Reporter: Jim Newsham
>            Assignee: Joshua McKenzie
>            Priority: Minor
>         Attachments: CASSANDRA-4050_v1.patch
>
>
> I'm using Cassandra 1.0.8, on Windows 7.  When I take a snapshot of the database, I find
that I am unable to delete the snapshot directory (i.e., dir named "{datadir}\{keyspacename}\snapshots\{snapshottag}")
while Cassandra is running:  "The action can't be completed because the folder or a file in
it is open in another program.  Close the folder or file and try again" [in Windows Explorer].
 If I terminate Cassandra, then I can delete the directory with no problem.
> I expect to be able to move or delete the snapshotted files while Cassandra is running,
as this should not affect the runtime operation of Cassandra.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message