Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Tue, 25 Feb 2014 03:02:00 +0000 (UTC)
From: "Edward Capriolo (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12696811.1393184146743.97987.1393297320617@arcas>
In-Reply-To: <JIRA.12696811.1393184146743@arcas>
References: <JIRA.12696811.1393184146743@arcas>
Subject: [jira] [Comment Edited] (CASSANDRA-6757) SliceQueryFilter can
 accept multiple ColumnSlice but not exposed to thrift
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CASSANDRA-6757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13911167#comment-13911167 ] 

Edward Capriolo edited comment on CASSANDRA-6757 at 2/25/14 3:00 AM:
---------------------------------------------------------------------

I can understand that prospective, but I think repeating the mistakes of the past is a bad thing. .We are already doing similar things with triggers. Notice the TriggerDef:

{code}
struct TriggerDef {
    1: required string name,
    2: required map<string,string> options
}
{code}

{code}
list<ColumnOrSuperColumn> get_multi_slice(1:required MultiSliceRequest request)
                            throws (1:InvalidRequestException ire, 2:UnavailableException ue, 3:TimedOutException te),
{code}

Honestly I like my technique better, a required map of <string,string> for "future proofing" something seems like a less attractive idea then using optional fields.


was (Author: appodictic):
I can understand that prospective, but I think repeating the mistakes of the past is a bad thing. .We are already doing similar things with triggers. Notice the TriggerDef:

{code}
struct TriggerDef {
    1: required string name,
    2: required map<string,string> options
}
{code}

{code}
list<ColumnOrSuperColumn> get_multi_slice(1:required MultiSliceRequest request)
                            throws (1:InvalidRequestException ire, 2:UnavailableException ue, 3:TimedOutException te),
{code}

Honestly I like my technique better, a required map of <string,string> for "future proofing" something seems like a less attractive idea then using optional fields properly.

> SliceQueryFilter can accept multiple ColumnSlice but not exposed to thrift
> --------------------------------------------------------------------------
>
>                 Key: CASSANDRA-6757
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6757
>             Project: Cassandra
>          Issue Type: New Feature
>            Reporter: Edward Capriolo
>            Assignee: Edward Capriolo
>         Attachments: Cassandra-6757.1.diff
>
>
> Thrift has getSlice() which takes a key and a predicate. SliceQueryFilter can accept multiple ColumnSlice(s). Users should have access to this capability already found in Cassandra.


--
This message was sent by Atlassian JIRA
(v6.1.5#6160)