Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EE13F102DA for ; Tue, 11 Feb 2014 18:06:34 +0000 (UTC) Received: (qmail 36649 invoked by uid 500); 11 Feb 2014 18:06:33 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 36565 invoked by uid 500); 11 Feb 2014 18:06:32 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 36404 invoked by uid 99); 11 Feb 2014 18:06:27 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Feb 2014 18:06:27 +0000 Date: Tue, 11 Feb 2014 18:06:27 +0000 (UTC) From: "Aleksey Yeschenko (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (CASSANDRA-6662) Sort/reconcile cells in ArrayBackedSortedColumns only when an accessor is called MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-6662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13898085#comment-13898085 ] Aleksey Yeschenko edited comment on CASSANDRA-6662 at 2/11/14 6:05 PM: ----------------------------------------------------------------------- Accepted nits #1, #2, #4 and #5 and committed, thanks. As for #3 - got rid of the binarySearch() there, but did leave the reconcile-with-previous-cell logic in place (for one, we've already done the comparison, so it makes sense to use the result; secondly, it does happen more often than you think - when merging results from memtabe+sstables on read in CollationController.collectAllData). Actually, returned the binarySearch() logic back as well. It should have a significant enough affect on CollationController.collectTimeOrderedData(), and only adds one more branch on top, anyway (in 6de2fd9bfd4c20e47495d171da7175c1a9e92c68). was (Author: iamaleksey): Accepted nits #1, #2, #4 and #5 and committed, thanks. As for #4 - got rid of the binarySearch() there, but did leave the reconcile-with-previous-cell logic in place (for one, we've already done the comparison, so it makes sense to use the result; secondly, it does happen more often than you think - when merging results from memtabe+sstables on read in CollationController.collectAllData). Actually, returned the binarySearch() logic back as well. It should have a significant enough affect on CollationController.collectTimeOrderedData(), and only adds one more branch on top, anyway (in 6de2fd9bfd4c20e47495d171da7175c1a9e92c68). > Sort/reconcile cells in ArrayBackedSortedColumns only when an accessor is called > -------------------------------------------------------------------------------- > > Key: CASSANDRA-6662 > URL: https://issues.apache.org/jira/browse/CASSANDRA-6662 > Project: Cassandra > Issue Type: Improvement > Reporter: Aleksey Yeschenko > Assignee: Aleksey Yeschenko > Fix For: 2.1 > > > To avoid poor performance with huge numbers of cells added out of order (which should be rare, but *can* happen with certain batch scenarios) we should make ABSC only sort/reconcile its cells when an actual accessor is actually called, delaying sorting until the very end. -- This message was sent by Atlassian JIRA (v6.1.5#6160)