Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 383C510E3D for ; Mon, 3 Feb 2014 21:41:08 +0000 (UTC) Received: (qmail 33041 invoked by uid 500); 3 Feb 2014 21:41:07 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 33012 invoked by uid 500); 3 Feb 2014 21:41:07 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 32849 invoked by uid 99); 3 Feb 2014 21:41:06 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Feb 2014 21:41:06 +0000 Date: Mon, 3 Feb 2014 21:41:06 +0000 (UTC) From: "Jonathan Ellis (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-6510) Don't drop local mutations without a trace MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-6510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13889949#comment-13889949 ] Jonathan Ellis commented on CASSANDRA-6510: ------------------------------------------- Nope, that's not the implication. You can easily see from the code that {{responseHandler.response}} only gets called after {{rm.apply}}. That is, no write is acknowledge if it hasn't actually been applied. > Don't drop local mutations without a trace > ------------------------------------------ > > Key: CASSANDRA-6510 > URL: https://issues.apache.org/jira/browse/CASSANDRA-6510 > Project: Cassandra > Issue Type: Bug > Reporter: Aleksey Yeschenko > Assignee: Aleksey Yeschenko > Fix For: 1.2.14, 2.0.4 > > Attachments: 6510.txt > > > SP.insertLocal() uses a regular DroppableRunnable, thus timed out local mutations get dropped without leaving a trace. SP.insertLocal() should be using LocalMutationRunnable instead. -- This message was sent by Atlassian JIRA (v6.1.5#6160)