Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Thu, 20 Feb 2014 23:17:27 +0000 (UTC)
From: "Joshua McKenzie (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12677050.1383310345911.77418.1392938247676@arcas>
In-Reply-To: <JIRA.12677050.1383310345911@arcas>
References: <JIRA.12677050.1383310345911@arcas>
Subject: [jira] [Commented] (CASSANDRA-6283) Windows 7 data files keept open
 / can't be deleted after compaction.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CASSANDRA-6283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13907685#comment-13907685 ] 

Joshua McKenzie commented on CASSANDRA-6283:
--------------------------------------------

As a final confirmation of this behavior I tested this locally.  I created and locked a file named test.txt (opened it), and then hard linked and attempted to delete it.

C:\Users\jmckenzie\Desktop\FileLocker>mklink /H link.txt test.txt
Hardlink created for link.txt <<===>> test.txt

C:\Users\jmckenzie\Desktop\FileLocker>del link.txt
C:\Users\jmckenzie\Desktop\FileLocker\link.txt
The process cannot access the file because it is being used by another process.

On Windows, if the original file is locked the hard link cannot be deleted even if it's not in use.

I'll start prototyping a sweep and delete model.  We have some unit tests that are failing on Windows with similar stacks to what Andreas is getting on startup so I'll look into those along with this.

> Windows 7 data files keept open / can't be deleted after compaction.
> --------------------------------------------------------------------
>
>                 Key: CASSANDRA-6283
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6283
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>         Environment: Windows 7 (32) / Java 1.7.0.45
>            Reporter: Andreas Schnitzerling
>            Assignee: Joshua McKenzie
>              Labels: compaction
>             Fix For: 2.0.6
>
>         Attachments: leakdetect.patch, screenshot-1.jpg, system.log
>
>
> Files cannot be deleted, patch CASSANDRA-5383 (Win7 deleting problem) doesn't help on Win-7 on Cassandra 2.0.2. Even 2.1 Snapshot is not running. The cause is: Opened file handles seem to be lost and not closed properly. Win 7 blames, that another process is still using the file (but its obviously cassandra). Only restart of the server makes the files deleted. But after heavy using (changes) of tables, there are about 24K files in the data folder (instead of 35 after every restart) and Cassandra crashes. I experiminted and I found out, that a finalizer fixes the problem. So after GC the files will be deleted (not optimal, but working fine). It runs now 2 days continously without problem. Possible fix/test:
> I wrote the following finalizer at the end of class org.apache.cassandra.io.util.RandomAccessReader:
> {code:title=RandomAccessReader.java|borderStyle=solid}
> @Override
> protected void finalize() throws Throwable {
> 	deallocate();
> 	super.finalize();
> }
> {code}
> Can somebody test / develop / patch it? Thx.


--
This message was sent by Atlassian JIRA
(v6.1.5#6160)