cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tyler Hobbs (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-6757) SliceQueryFilter can accept multiple ColumnSlice but not exposed to thrift
Date Wed, 26 Feb 2014 18:00:29 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-6757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13913239#comment-13913239
] 

Tyler Hobbs commented on CASSANDRA-6757:
----------------------------------------

Personally, I don't actually mind using a MultiSliceRequest object for the parameter all that
much.  It's true that it's not consistent with the rest of the Thrift API, but most of the
points Ed raises about that are good.  If somebody feels strongly about it, I'll defer to
them.

Regardless, there are a few things that need to be changed:

{{CassandraServer.get_multi_slice()}}:
* remove TException from the throws list
* fix logger.debug("remove_counter")
* remove redundant "ReadCommand" on ArrayList<ReadCommand>
* align the indentation on the map
* ReadCommand timestamp should be System.currentTimeMillis(), not System.nanoTime()
* Need to validate start <= end on each slice unless reversed == true

In {{CassandraServer.fixOptionalSliceParameters()}}, you can drop the curly braces on the
single-line "if" statements.

You added an unneeded import in ColumnFamilyStore.java.

{{MultiSliceEndToEndTest}}:
* Just name it MultiSliceTest
* add tests for bad slices ends
* remove IRE throws from setup()

> SliceQueryFilter can accept multiple ColumnSlice but not exposed to thrift
> --------------------------------------------------------------------------
>
>                 Key: CASSANDRA-6757
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6757
>             Project: Cassandra
>          Issue Type: New Feature
>            Reporter: Edward Capriolo
>            Assignee: Edward Capriolo
>         Attachments: Cassandra-6757.1.diff
>
>
> Thrift has getSlice() which takes a key and a predicate. SliceQueryFilter can accept
multiple ColumnSlice(s). Users should have access to this capability already found in Cassandra.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message