cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvain Lebresne (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-6697) Refactor Cell and CellName ByteBuffer accessors to avoid garbage allocation where possible
Date Thu, 13 Feb 2014 07:27:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-6697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13900094#comment-13900094
] 

Sylvain Lebresne commented on CASSANDRA-6697:
---------------------------------------------

That's a very initial remark from a very quick look at the patch, but this seems to make things
pretty fragile and hard to maintain. Feels a bit too simple to pass the wrong scope and end
up with a hard to diagnose bug. That's the kind of thing that I rather not see us do without
concrete evidence (aka numbers, and not just micro-benchmarks) that the gains are worth the
increased complexity. Otherwise this sound like premature optimization to me.

> Refactor Cell and CellName ByteBuffer accessors to avoid garbage allocation where possible
> ------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-6697
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6697
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Benedict
>             Fix For: 2.1
>
>
> This is a prerequisite for CASSANDRA-6689.
> The basic idea is to, if unsafe is available, abuse it to modify preallocated ByteBuffers
so that when they are short lived they do not need to be instantiated. Initially this will
only be helpful for comparisons and lookups on the BBs, but with some modifications to the
read path we should be able to reduce the need in CASSANDRA-6689 to construct BBs to pass
to the native protocol (thrift may have to continue as is)



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message