Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1404810D1F for ; Fri, 17 Jan 2014 17:32:25 +0000 (UTC) Received: (qmail 30135 invoked by uid 500); 17 Jan 2014 17:32:21 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 30032 invoked by uid 500); 17 Jan 2014 17:32:20 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 29948 invoked by uid 99); 17 Jan 2014 17:32:20 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Jan 2014 17:32:20 +0000 Date: Fri, 17 Jan 2014 17:32:20 +0000 (UTC) From: "Chris Burroughs (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-6591) un-deprecate cache recentHitRate and expose in o.a.c.metrics MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-6591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13874981#comment-13874981 ] Chris Burroughs commented on CASSANDRA-6591: -------------------------------------------- By fake events I meant that instead of updating a field each poll could update a meter. That's "fake" because it's not measuring any real rate of things happening before unit time, just how often we happen to be polling. I suppose though that that we could use the moving average class from metrics directly, and then expose 1/5/15m averages as guages on CacheMetrics. Is that preferable? > un-deprecate cache recentHitRate and expose in o.a.c.metrics > ------------------------------------------------------------ > > Key: CASSANDRA-6591 > URL: https://issues.apache.org/jira/browse/CASSANDRA-6591 > Project: Cassandra > Issue Type: Improvement > Components: Core > Reporter: Chris Burroughs > Assignee: Chris Burroughs > Priority: Minor > Attachments: j6591-1.2-v1.txt, j6591-1.2-v2.txt > > > recentHitRate metrics were not added as part of CASSANDRA-4009 because there is not an obvious way to do it with the Metrics library. Instead hitRate was added as an all time measurement since node restart. > This does allow changes in cache rate (aka production performance problems) to be detected. Ideally there would be 1/5/15 moving averages for the hit rate, but I'm not sure how to calculate that. Instead I propose updating recentHitRate on a fixed interval and exposing that as a Gauge. -- This message was sent by Atlassian JIRA (v6.1.5#6160)