Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 99FC610A71 for ; Thu, 2 Jan 2014 23:03:50 +0000 (UTC) Received: (qmail 88030 invoked by uid 500); 2 Jan 2014 23:03:50 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 88008 invoked by uid 500); 2 Jan 2014 23:03:50 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 88000 invoked by uid 99); 2 Jan 2014 23:03:50 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Jan 2014 23:03:50 +0000 Date: Thu, 2 Jan 2014 23:03:50 +0000 (UTC) From: "J Potter (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-5930) Offline scrubs can choke on broken files MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-5930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13860912#comment-13860912 ] J Potter commented on CASSANDRA-5930: ------------------------------------- Hi Tyler -- based on my notes, it should have been Cassandra 1.2.6.1 (DSE 3.1), at least, that's what other tickets we have filed at this same time suggest. > Offline scrubs can choke on broken files > ---------------------------------------- > > Key: CASSANDRA-5930 > URL: https://issues.apache.org/jira/browse/CASSANDRA-5930 > Project: Cassandra > Issue Type: Bug > Reporter: Jeremiah Jordan > Assignee: Tyler Hobbs > Priority: Minor > > There are cases where offline scrub can hit an exception and die, like: > {noformat} > WARNING: Non-fatal error reading row (stacktrace follows) > Exception in thread "main" java.io.IOError: java.io.IOError: java.io.EOFException > at org.apache.cassandra.db.compaction.Scrubber.scrub(Scrubber.java:242) > at org.apache.cassandra.tools.StandaloneScrubber.main(StandaloneScrubber.java:121) > Caused by: java.io.IOError: java.io.EOFException > at org.apache.cassandra.db.compaction.PrecompactedRow.merge(PrecompactedRow.java:116) > at org.apache.cassandra.db.compaction.PrecompactedRow.(PrecompactedRow.java:99) > at org.apache.cassandra.db.compaction.CompactionController.getCompactedRow(CompactionController.java:176) > at org.apache.cassandra.db.compaction.CompactionController.getCompactedRow(CompactionController.java:182) > at org.apache.cassandra.db.compaction.Scrubber.scrub(Scrubber.java:171) > ... 1 more > Caused by: java.io.EOFException > at java.io.RandomAccessFile.readFully(RandomAccessFile.java:399) > at java.io.RandomAccessFile.readFully(RandomAccessFile.java:377) > at org.apache.cassandra.utils.BytesReadTracker.readFully(BytesReadTracker.java:95) > at org.apache.cassandra.utils.ByteBufferUtil.read(ByteBufferUtil.java:401) > at org.apache.cassandra.utils.ByteBufferUtil.readWithLength(ByteBufferUtil.java:363) > at org.apache.cassandra.db.ColumnSerializer.deserialize(ColumnSerializer.java:120) > at org.apache.cassandra.db.ColumnSerializer.deserialize(ColumnSerializer.java:37) > at org.apache.cassandra.db.ColumnFamilySerializer.deserializeColumns(ColumnFamilySerializer.java:144) > at org.apache.cassandra.io.sstable.SSTableIdentityIterator.getColumnFamilyWithColumns(SSTableIdentityIterator.java:234) > at org.apache.cassandra.db.compaction.PrecompactedRow.merge(PrecompactedRow.java:112) > ... 5 more > {noformat} > Since the purpose of offline scrub is to fix broken stuff, it should be more resilient to broken stuff... -- This message was sent by Atlassian JIRA (v6.1.5#6160)