cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvain Lebresne (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CASSANDRA-6580) Deadcode in AtomicSortedColumns
Date Tue, 14 Jan 2014 13:15:50 GMT

     [ https://issues.apache.org/jira/browse/CASSANDRA-6580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Sylvain Lebresne updated CASSANDRA-6580:
----------------------------------------

    Attachment: 6580.txt

> Deadcode in AtomicSortedColumns
> -------------------------------
>
>                 Key: CASSANDRA-6580
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6580
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Sylvain Lebresne
>            Assignee: Sylvain Lebresne
>            Priority: Trivial
>         Attachments: 6580.txt
>
>
> In AtomicSortedColumns we have this:
> {noformat}                  
> // for memtable updates we only care about oldcolumn, reconciledcolumn, but when compacting
> // we need to make sure we update indexes no matter the order we merge
> if (reconciledColumn == column)
>     indexer.update(oldColumn, reconciledColumn);
> else
>     indexer.update(column, reconciledColumn);
> {noformat}
> This makes no sense anymore however since AtomicSortedColumns is not used anymore during
compaction (and index removal is dealt with by the CompactedRow implementations).
> Attaching trivial patch against 2.0. This affects 1.2 too and maybe before (haven't check)
but it's harmless anyway and we probably won't have much release of pre-2.0 versions anymore.
Still, the code is a tad confusing so it's maybe worth cleaning it up in 2.0.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message