cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvain Lebresne (JIRA)" <>
Subject [jira] [Created] (CASSANDRA-6580) Deadcode in AtomicSortedColumns
Date Tue, 14 Jan 2014 13:13:50 GMT
Sylvain Lebresne created CASSANDRA-6580:

             Summary: Deadcode in AtomicSortedColumns
                 Key: CASSANDRA-6580
             Project: Cassandra
          Issue Type: Improvement
            Reporter: Sylvain Lebresne
            Assignee: Sylvain Lebresne
            Priority: Trivial

In AtomicSortedColumns we have this:
// for memtable updates we only care about oldcolumn, reconciledcolumn, but when compacting
// we need to make sure we update indexes no matter the order we merge
if (reconciledColumn == column)
    indexer.update(oldColumn, reconciledColumn);
    indexer.update(column, reconciledColumn);
This makes no sense anymore however since AtomicSortedColumns is not used anymore during compaction
(and index removal is dealt with by the CompactedRow implementations).

Attaching trivial patch against 2.0. This affects 1.2 too and maybe before (haven't check)
but it's harmless anyway and we probably won't have much release of pre-2.0 versions anymore.
Still, the code is a tad confusing so it's maybe worth cleaning it up in 2.0.

This message was sent by Atlassian JIRA

View raw message