cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yuki Morishita (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-6503) sstables from stalled repair sessions become live after a reboot and can resurrect deleted data
Date Fri, 10 Jan 2014 18:54:59 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-6503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13868124#comment-13868124
] 

Yuki Morishita commented on CASSANDRA-6503:
-------------------------------------------

I think you are right. We don't want to close SSTR again for renaming.
Let's stick with deferring closeAndOpenReader as you did.
For the patch, I think it would be nice to call SSTW.abort() to discard already received file
when something bad happened.

bq. Interesting. What problems do you see this solving (I'm probably missing something in
my understanding)?

If the node goes down during we are doing closeAndOpenReader to received files, there is a
chance we have already renamed files.
So I wanted to make sure the node won't read those files when the node come up.


> sstables from stalled repair sessions become live after a reboot and can resurrect deleted
data
> -----------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-6503
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6503
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Jeremiah Jordan
>            Assignee: Jason Brown
>            Priority: Minor
>             Fix For: 1.2.14, 2.0.5
>
>         Attachments: 6503_c1.2-v1.patch
>
>
> The sstables streamed in during a repair session don't become active until the session
finishes.  If something causes the repair session to hang for some reason, those sstables
will hang around until the next reboot, and become active then.  If you don't reboot for 3
months, this can cause data to resurrect, as GC grace has expired, so tombstones for the data
in those sstables may have already been collected.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message