cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvain Lebresne (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-6414) BlacklistingCompactionsTest fails in trunk
Date Thu, 16 Jan 2014 13:17:20 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13873351#comment-13873351
] 

Sylvain Lebresne commented on CASSANDRA-6414:
---------------------------------------------

bq. That should be purely cosmetic, and indeed reverting f3dc188e203b3db980ee81df05390968043cb601
still leaves BCT erroring out.

I'll call your bluff!

As far as I can tell, the actual error that makes the test error out is
{noformat}
    [junit] java.lang.RuntimeException: java.util.NoSuchElementException
    [junit] 	at org.apache.cassandra.db.ColumnFamilyStore.runWithCompactionsDisabled(ColumnFamilyStore.java:2076)
    [junit] 	at org.apache.cassandra.db.ColumnFamilyStore.truncateBlocking(ColumnFamilyStore.java:2020)
    [junit] 	at org.apache.cassandra.db.compaction.BlacklistingCompactionsTest.testBlacklisting(BlacklistingCompactionsTest.java:153)
    [junit] 	at org.apache.cassandra.db.compaction.BlacklistingCompactionsTest.testBlacklistingWithLeveledCompactionStrategy(BlacklistingCompactionsTest.java:67)
    [junit] Caused by: java.util.NoSuchElementException
    [junit] 	at java.util.Collections$EmptyIterator.next(Collections.java:3006)
    [junit] 	at com.google.common.collect.Ordering.max(Ordering.java:536)
    [junit] 	at com.google.common.collect.Ordering.max(Ordering.java:555)
    [junit] 	at org.apache.cassandra.db.compaction.LeveledManifest.replace(LeveledManifest.java:142)
    [junit] 	at org.apache.cassandra.db.compaction.LeveledCompactionStrategy.handleNotification(LeveledCompactionStrategy.java:162)
    [junit] 	at org.apache.cassandra.db.DataTracker.notifySSTablesChanged(DataTracker.java:469)
    [junit] 	at org.apache.cassandra.db.DataTracker.markObsolete(DataTracker.java:246)
    [junit] 	at org.apache.cassandra.db.ColumnFamilyStore.markObsolete(ColumnFamilyStore.java:1097)
    [junit] 	at org.apache.cassandra.db.ColumnFamilyStore.discardSSTables(ColumnFamilyStore.java:2359)
    [junit] 	at org.apache.cassandra.db.ColumnFamilyStore$10.run(ColumnFamilyStore.java:2004)
    [junit] 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
    [junit] 	at org.apache.cassandra.db.ColumnFamilyStore.runWithCompactionsDisabled(ColumnFamilyStore.java:2072)
{noformat}
and as it happens, due to f3dc188e203b3db980ee81df05390968043cb601, {{SSTableReader.sstableOrdering.max(added).last}}
will be called even when {{added}} is empty, which is clearly documented as wrong for Ordering.max().
And while BCT fails every time for me on trunk, it does work fine with f3dc188e203b3db980ee81df05390968043cb601
reverted (it does log a bunch of ERROR because compaction complains about the sstable being
corrupted, which is correct, and I do have to bump the test timeout on my box to not have
the test timeout, but it does pass).

Haven't reverted f3dc188e203b3db980ee81df05390968043cb601 yet because I'm not sure what was
the initial intent of that commit tbh.

> BlacklistingCompactionsTest fails in trunk
> ------------------------------------------
>
>                 Key: CASSANDRA-6414
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6414
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tests
>            Reporter: Jonathan Ellis
>            Assignee: Sylvain Lebresne
>             Fix For: 2.1
>
>         Attachments: 6414_out.txt
>
>
> Passes in 2.0 HEAD.  Bisect should be relatively easy.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message