cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Clément Lardeur (JIRA) <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-6381) Refactor nodetool
Date Sun, 12 Jan 2014 10:10:59 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-6381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13868988#comment-13868988
] 

Clément Lardeur commented on CASSANDRA-6381:
--------------------------------------------

bq. Hmm, git apply and patch both ignore the binary jars 

Have you tried the {{--binary}} option for {{git apply}} ?

I used it to create the patch :
{code}
git diff --binary origin/trunk > trunk-6381.patch
{code}

But no matter, you have already included the files manually :)


> Refactor nodetool
> -----------------
>
>                 Key: CASSANDRA-6381
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6381
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Yuki Morishita
>            Assignee: Clément Lardeur
>            Priority: Minor
>              Labels: lhf, nodetool
>         Attachments: trunk-6381-v2.patch, trunk-6381-v3.patch, trunk-6381-v4.patch, trunk-6381.patch
>
>
> We have way too many nodetool commands(more than 40) packed in one NodeCmd class. And
we are trying to add more commands.
> https://github.com/airlift/airline could be a good fit to take out each command into
sub command class.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message