cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Ellis (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-5549) Remove Table.switchLock
Date Mon, 27 Jan 2014 04:57:41 GMT


Jonathan Ellis commented on CASSANDRA-5549:

Okay, went with plan B of unifying MT/Pool and MO/Allocator.  Pretty happy with how this worked

In my mind, off heap stuff can now be added by creating an appropriate Allocator class, and
a Pool implementation that owns two sub-pools.

(I'm seeing a bunch of test failures but I don't think it's from this refactor.)

> Remove Table.switchLock
> -----------------------
>                 Key: CASSANDRA-5549
>                 URL:
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Jonathan Ellis
>            Assignee: Benedict
>              Labels: performance
>             Fix For: 2.1
>         Attachments: 5549-removed-switchlock.png, 5549-sunnyvale.png
> As discussed in CASSANDRA-5422, Table.switchLock is a bottleneck on the write path. 
ReentrantReadWriteLock is not lightweight, even if there is no contention per se between readers
and writers of the lock (in Cassandra, memtable updates and switches).

This message was sent by Atlassian JIRA

View raw message