cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mikhail Stepura (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-6418) auto_snapshots are not removable via 'nodetool clearsnapshot'
Date Thu, 05 Dec 2013 05:16:39 GMT


Mikhail Stepura commented on CASSANDRA-6418:

{code}    [javac] C:\Users\mishail\workspace\cassandra\src\java\org\apache\cassandra\db\compaction\
error: cannot find symbol
    [javac]                 cfs.clearSnapshot(snapshotName);
    [javac]                    ^
    [javac]   symbol:   method clearSnapshot(String)
    [javac]   location: variable cfs of type ColumnFamilyStore

For *getAllKSDirectories*
* {{List<File> snapshotDirs = new ArrayList();}} .It's a raw data type.  You probably
meant either {{newArrayList()}} or {{new ArrayList<>()}}
* {{new File(dataDirectory + "/"  + ksName)}} and {{File(dataDirectory + "/"  + ksName + "/"
+ cfDir)}} - you should use {{org.apache.cassandra.db.Directories.join(String...)}} instead
that concatenation.
* I think it would be better to use one of {{File.listFiles}} methods instead of {{File.list()}}

> auto_snapshots are not removable via 'nodetool clearsnapshot'
> -------------------------------------------------------------
>                 Key: CASSANDRA-6418
>                 URL:
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tools
>         Environment: auto_snapshot: true
>            Reporter: J. Ryan Earl
>            Assignee: Lyuben Todorov
>            Priority: Minor
>             Fix For: 2.0.4
>         Attachments: 6418_cassandra-2.0.patch
> Snapshots of deleted CFs created via the "auto_snapshot" configuration parameter appear
to not be tracked.  The result is that 'nodetool clearsnapshot <keyspace with deleted CFs>'
does nothing, and short of manually removing the files from the filesystem, deleted CFs remain
indefinitely taking up space.
> I'm not sure if this is intended, but it seems pretty counter-intuitive.  I haven't found
any documentation that indicates "auto_snapshots" would be ignored by 'nodetool clearsnapshot'.

This message was sent by Atlassian JIRA

View raw message