cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mikhail Stepura (JIRA)" <>
Subject [jira] [Updated] (CASSANDRA-6418) auto_snapshots are not removable via 'nodetool clearsnapshot'
Date Sat, 21 Dec 2013 00:06:09 GMT


Mikhail Stepura updated CASSANDRA-6418:

    Attachment: CASSANDRA-2.0-6418_v4.patch

Looking at that duplicated code in {{getKSDirectories}} and {{getCFDirectory}}, and in {{getCFDirectory}}
and {{Directories}}'s constructor, it occured to me that we don't need to call {{getCFDirectory}}
in a static context. The only place it's used is {{doValidationCompaction}} where we always
have a reference to CFS.

I'm attaching V4 of the patch. [~lyubent] what do you think?

> auto_snapshots are not removable via 'nodetool clearsnapshot'
> -------------------------------------------------------------
>                 Key: CASSANDRA-6418
>                 URL:
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tools
>         Environment: auto_snapshot: true
>            Reporter: J. Ryan Earl
>            Assignee: Lyuben Todorov
>            Priority: Minor
>             Fix For: 2.0.5
>         Attachments: 6418_cassandra-2.0.patch, 6418_v2.patch, 6418_v3_cassandra-2.0.patch,
> Snapshots of deleted CFs created via the "auto_snapshot" configuration parameter appear
to not be tracked.  The result is that 'nodetool clearsnapshot <keyspace with deleted CFs>'
does nothing, and short of manually removing the files from the filesystem, deleted CFs remain
indefinitely taking up space.
> I'm not sure if this is intended, but it seems pretty counter-intuitive.  I haven't found
any documentation that indicates "auto_snapshots" would be ignored by 'nodetool clearsnapshot'.

This message was sent by Atlassian JIRA

View raw message