cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lyuben Todorov (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-6157) Selectively Disable hinted handoff for a data center
Date Wed, 18 Dec 2013 10:28:10 GMT


Lyuben Todorov commented on CASSANDRA-6157:

patch does what it says however there are some nits: 

In DatabaseDescriptor#setHintedHandoffEnabledOverride, why do you create a new map and set
{{conf.hinted_handoff_enabled_override_by_dc}} to said new map instead of just adding the
key and value directly to {{conf.hinted_handoff_enabled_override_by_dc}}?

Code formatting:
// braces should be on a new line
1. StorageProxy.shouldHint(...)
      if(!DatabaseDescriptor.shouldHintForDC(dc)) {
2. NodeProbe.enableHintedHandoff(...) {
3. NodeProbe.disableHintedHandoff(...) {

HintedHandoffEnabledOverride seems somewhat confusing, could we possibly change it to HintedHandoffPerDC
or HintedHandoffDCOverride ([~jbellis] WDUT?)

> Selectively Disable hinted handoff for a data center
> ----------------------------------------------------
>                 Key: CASSANDRA-6157
>                 URL:
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: sankalp kohli
>            Assignee: sankalp kohli
>            Priority: Minor
>             Fix For: 2.0.4
>         Attachments: trunk-6157.txt
> Cassandra supports disabling the hints or reducing the window for hints. 
> It would be helpful to have a switch which stops hints to a down data center but continue
hints to other DCs.
> This is helpful during data center fail over as hints will put more unnecessary pressure
on the DC taking double traffic. Also since now Cassandra is under reduced reduncany, we don't
want to disable hints within the DC. 

This message was sent by Atlassian JIRA

View raw message