cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvain Lebresne (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-5864) Scrub should discard the columns from CFMetaData.droppedColumns map (if they are old enough)
Date Tue, 03 Dec 2013 20:31:35 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13838140#comment-13838140
] 

Sylvain Lebresne commented on CASSANDRA-5864:
---------------------------------------------

Are we sure it doesn't do it already? My reading of the code is that dropped columns are removed
by CFS.removeDeleted() and this, irregardless of gcBefore (as should be). Since LazilyCompactedRow
calls CFS.removeDeleted() and scrub uses LazilyCompactedRow .... Am I missing something?

As for whether scrub should or should not drop them, I'd go with "it doesn't really matter
so let's do whatever is easier".

> Scrub should discard the columns from CFMetaData.droppedColumns map (if they are old
enough)
> --------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-5864
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5864
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Aleksey Yeschenko
>            Assignee: Tyler Hobbs
>            Priority: Minor
>              Labels: scrub
>
> CASSANDRA-3919 restored ALTER TABLE DROP support in CQL3 and it would be nice to make
scrub dropped-columns-aware.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message