cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Ellis (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-3578) Multithreaded commitlog
Date Sun, 01 Dec 2013 00:09:35 GMT


Jonathan Ellis commented on CASSANDRA-3578:

bq. If there's no room, we point to the end of the file, which is completely safe

My point is that the "no room" case can be a false positive when {{discardUnusedTail}} has
consumed space that isn't actually written to.

bq. I would suggest rolling back your isFullySynced() removal and next=>last rename changes

Which part?  The nonclemature is obviously correct this way. :)  (Re-read sync, we point the
"last" to the "next", before we were pointing "next" to "next" which is kind of nonsensical.)

> Multithreaded commitlog
> -----------------------
>                 Key: CASSANDRA-3578
>                 URL:
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Jonathan Ellis
>            Assignee: Benedict
>            Priority: Minor
>              Labels: performance
>         Attachments: 0001-CASSANDRA-3578.patch,, Current-CL.png,
Multi-Threded-CL.png,, latency.svg, oprate.svg, parallel_commit_log_2.patch
> Brian Aker pointed out a while ago that allowing multiple threads to modify the commitlog
simultaneously (reserving space for each with a CAS first, the way we do in the SlabAllocator.Region.allocate)
can improve performance, since you're not bottlenecking on a single thread to do all the copying
and CRC computation.
> Now that we use mmap'd CommitLog segments (CASSANDRA-3411) this becomes doable.
> (moved from CASSANDRA-622, which was getting a bit muddled.)

This message was sent by Atlassian JIRA

View raw message