Return-Path: 
 <commits-return-87016-apmail-cassandra-commits-archive=cassandra.apache.org@cassandra.apache.org>
X-Original-To: apmail-cassandra-commits-archive@www.apache.org
Delivered-To: apmail-cassandra-commits-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 8ECAD10FD6
	for <apmail-cassandra-commits-archive@www.apache.org>;
 Wed, 27 Nov 2013 17:54:11 +0000 (UTC)
Received: (qmail 4407 invoked by uid 500); 27 Nov 2013 17:47:42 -0000
Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org
Received: (qmail 4282 invoked by uid 500); 27 Nov 2013 17:47:39 -0000
Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:commits-help@cassandra.apache.org>
List-Unsubscribe: <mailto:commits-unsubscribe@cassandra.apache.org>
List-Post: <mailto:commits@cassandra.apache.org>
List-Id: <commits.cassandra.apache.org>
Reply-To: dev@cassandra.apache.org
Delivered-To: mailing list commits@cassandra.apache.org
Received: (qmail 4228 invoked by uid 99); 27 Nov 2013 17:47:36 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 Nov 2013 17:47:36 +0000
Date: Wed, 27 Nov 2013 17:47:36 +0000 (UTC)
From: "Jeremiah Jordan (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12681617.1385574448540.39512.1385574456649@arcas>
In-Reply-To: <JIRA.12681617.1385574448540@arcas>
References: <JIRA.12681617.1385574448540@arcas>
Subject: [jira] [Created] (CASSANDRA-6415) Snapshot repair block for ever is
 something happens to the "I made my snapshot" response
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394

Jeremiah Jordan created CASSANDRA-6415:
------------------------------------------

             Summary: Snapshot repair block for ever is something happens to the "I made my snapshot" response
                 Key: CASSANDRA-6415
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6415
             Project: Cassandra
          Issue Type: Bug
            Reporter: Jeremiah Jordan


The "snapshotLatch.await();" can be waiting for ever and block all repair operations indefinitely if something happens that another node doesn't respond.

{quote}
            public void makeSnapshots(Collection<InetAddress> endpoints)
            {
                try
                {
                    snapshotLatch = new CountDownLatch(endpoints.size());
                    IAsyncCallback callback = new IAsyncCallback()
                    {
                        public boolean isLatencyForSnitch()
                        {
                            return false;
                        }

                        public void response(MessageIn msg)
                        {
                            RepairJob.this.snapshotLatch.countDown();
                        }
                    };
                    for (InetAddress endpoint : endpoints)
                        MessagingService.instance().sendRR(new SnapshotCommand(tablename, cfname, sessionName, false).createMessage(), endpoint, callback);
                    snapshotLatch.await();
                    snapshotLatch = null;
                }
                catch (InterruptedException e)
                {
                    throw new RuntimeException(e);
                }
            }
{quote}



--
This message was sent by Atlassian JIRA
(v6.1#6144)