Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Tue, 26 Nov 2013 05:22:36 +0000 (UTC)
From: "Jonathan Ellis (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12675154.1382483931579.29143.1385443356297@arcas>
In-Reply-To: <JIRA.12675154.1382483931579@arcas>
References: <JIRA.12675154.1382483931579@arcas>
Subject: [jira] [Commented] (CASSANDRA-6231) Add snapshot disk space to
 cfstats
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CASSANDRA-6231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13832333#comment-13832333 ] 

Jonathan Ellis commented on CASSANDRA-6231:
-------------------------------------------

LGTM!

Last thing, the size methods in CFSMBean are deprecated because we're moving to CFMetrics.  Not much reason to add this to both places; let's just do it in metrics.  (So it's probably easier to just do this for trunk since otherwise you'd have to do support both in nodecmd.)

> Add snapshot disk space to cfstats
> ----------------------------------
>
>                 Key: CASSANDRA-6231
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6231
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Jonathan Ellis
>            Assignee: Mikhail Stepura
>            Priority: Minor
>              Labels: lhf
>         Attachments: CASSANDRA-2.0-6231-v2.patch, CASSANDRA-2.0-6231-v3.patch, CASSANDRA-2.0-6231.patch
>
>
> As discussed in CASSANDRA-6179, this could help avoid some user confusion, especially when snapshots are autocreated for drop/truncate.


--
This message was sent by Atlassian JIRA
(v6.1#6144)