cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mike Spertus (JIRA)" <j...@apache.org>
Subject [jira] [Created] (CASSANDRA-6420) CassandraStorage should not assume all DataBags are DefaultDataBags
Date Fri, 29 Nov 2013 02:42:35 GMT
Mike Spertus created CASSANDRA-6420:
---------------------------------------

             Summary: CassandraStorage should not assume all DataBags are DefaultDataBags
                 Key: CASSANDRA-6420
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6420
             Project: Cassandra
          Issue Type: Improvement
          Components: Hadoop
         Environment: All environments
            Reporter: Mike Spertus
             Fix For: 2.1, 2.0.2, 1.2.12



CassandraStorage improperly assumes all DataBags are DefaultDataBags. As a result, natural
Pig code can't be used with CassandraStorage. For example:
{quote}
{{B = FOREACH A GENERATE $0, TOBAG(TOTUPLE($1, $2));}}
{{STORE B into  'cassandra://MyKeySpace/MyColumnFamily' using CassandraStorage();}}
{quote}
fails with a complaint that a {{NonSpillableDataBag}} can't be converted into a {{DefaultDataBag}}.

Since the {{CassandraStorage}} code only calls methods from {{DataBag}}, there is no need
for this artifical restriction. After applying the attached patch, the above code works fine,
making CassandraStorage much easier to use.

This is my first submission to Cassandra, so I apologize for any incorrect process. Please
let me know what I should do differently. In particular, I am a little unclear where I should
put the test. I am thinking I should put it in ThriftColumnFamilyTest.java. Is this correct
or should it be somewhere else? I'll create a test as soon as I understand. 



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message