cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ryan McGuire (JIRA)" <>
Subject [jira] [Created] (CASSANDRA-6397) removenode outputs confusing non-error
Date Fri, 22 Nov 2013 18:00:38 GMT
Ryan McGuire created CASSANDRA-6397:

             Summary: removenode outputs confusing non-error
                 Key: CASSANDRA-6397
             Project: Cassandra
          Issue Type: Bug
            Reporter: Ryan McGuire
            Priority: Minor

*{{nodetool removenode force}}* outputs a slightly confusing error message when there is nothing
for it to do.

* Start a cluster, then kill one of the nodes.
* run *{{nodetool removenode}}* on the node you killed.
* Simultaneously, in another shell, run *{{nodetool removenode force}}*, see that it outputs
a simple message regarding it's status.
* Run *{{nodetool removenode force}}* again after the removenode finishes, you'll see this
message and traceback:

$ ~/.ccm/test/node1/bin/nodetool -p 7100 removenode force
xss =  -ea -javaagent:/home/ryan/.ccm/repository/git_cassandra-1.2/lib/jamm-0.2.5.jar -XX:+UseThreadPriorities
-XX:ThreadPriorityPolicy=42 -Xms1982M -Xmx1982M -Xmn400M -XX:+HeapDumpOnOutOfMemoryError -Xss228k
RemovalStatus: No token removals in process.
Exception in thread "main" java.lang.UnsupportedOperationException: No tokens to force removal
on, call 'removetoken' first
	at org.apache.cassandra.service.StorageService.forceRemoveCompletion(
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(
	at java.lang.reflect.Method.invoke(
	at com.sun.jmx.mbeanserver.StandardMBeanIntrospector.invokeM2(
	at com.sun.jmx.mbeanserver.StandardMBeanIntrospector.invokeM2(
	at com.sun.jmx.mbeanserver.MBeanIntrospector.invokeM(
	at com.sun.jmx.mbeanserver.PerInterface.invoke(
	at com.sun.jmx.mbeanserver.MBeanSupport.invoke(
	at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.invoke(
	at com.sun.jmx.mbeanserver.JmxMBeanServer.invoke(
	at sun.reflect.GeneratedMethodAccessor10.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(
	at java.lang.reflect.Method.invoke(
	at sun.rmi.server.UnicastServerRef.dispatch(
	at sun.rmi.transport.Transport$
	at sun.rmi.transport.Transport$
	at Method)
	at sun.rmi.transport.Transport.serviceCall(
	at sun.rmi.transport.tcp.TCPTransport.handleMessages(
	at sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run0(
	at sun.rmi.transport.tcp.TCPTransport$
	at java.util.concurrent.ThreadPoolExecutor.runWorker(
	at java.util.concurrent.ThreadPoolExecutor$

Two issues I see with this traceback:

* "No tokens to force removal on" is telling me the same thing that the message before it
tells me: "RemovalStatus: No token removals in process.", So the entire traceback is unnecessary
to output.
* "call 'removetoken' first" - removetoken has been deprecated according to the message output
by removenode, so there is inconsistency in directions.

This message was sent by Atlassian JIRA

View raw message