cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Brown (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-6347) LOCAL_ONE code in the native protocol is not the same in C* 1.2 and C* 2.0
Date Fri, 15 Nov 2013 06:17:20 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-6347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13823339#comment-13823339
] 

Jason Brown commented on CASSANDRA-6347:
----------------------------------------

Crap, I thought I fixed all the id madness across 1.2 vs 2.0, thrift  vs native protocol,
native protocol 1 vs 2. <sigh> . Thanks for discovering and fixing. 

+1


> LOCAL_ONE code in the native protocol is not the same in C* 1.2 and C* 2.0
> --------------------------------------------------------------------------
>
>                 Key: CASSANDRA-6347
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6347
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Sylvain Lebresne
>            Assignee: Sylvain Lebresne
>             Fix For: 1.2.12
>
>         Attachments: 6347.txt
>
>
> When LOCAL_ONE was added (CASSANDRA-6202), it was unfortunately not given the same code
(the one used by the native protocol) in C* 1.2 and C* 2.0.  In 1.2 it's 8 (even though the
specification document pretends it's 10) while it's 10 in 2.0.
> This basically breaks backward compatibility for the v1 protocol between C* 1.2 and C*
2.0. Now, we could "fix" 2.0 adding special cases for the v1 protocol but that's going to
be a bit of a pain, so instead I suggest to just switch to 10 in 1.2. Since the spec was wrong
anyway and nobody complained so far this suggest no-one has really added support for LOCAL_ONE
in the native protocol against 1.2.11, so if we change it now we can just say to people to
upgrade to 1.2.12 directly if they want to use LOCAL_ONE with the native protocol. Attaching
simple patch for that.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message