cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tyler Hobbs (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-5519) Reduce index summary memory use for cold sstables
Date Thu, 21 Nov 2013 18:10:36 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-5519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13829170#comment-13829170
] 

Tyler Hobbs commented on CASSANDRA-5519:
----------------------------------------

This should be good for a second round of reviewing.  I opened a pull request against my own
repo so that you can comment inline, if you'd like: https://github.com/thobbs/cassandra/pull/1

Changes since the last review:
* The entire {{SSTableReader}} is replaced instead of just the IndexSummary.
* Space used by compacting SSTables is accounted for
* Enough extra space is reserved to cover rebuilding the largest summary
* In order to stay within the memory usage limit on startup, the on-disk Summary is replaced
whenever it is resampled.  I increased the threshold for downsampling to make this less frequent.
 The alternative would be to always keep the full summary on disk and have a somewhat more
complicated startup procedure.  I would appreciate your thoughts on this.

> Reduce index summary memory use for cold sstables
> -------------------------------------------------
>
>                 Key: CASSANDRA-5519
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5519
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: Jonathan Ellis
>            Assignee: Tyler Hobbs
>            Priority: Minor
>             Fix For: 2.1
>
>         Attachments: downsample.py
>
>




--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message