Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Mon, 14 Oct 2013 09:19:44 +0000 (UTC)
From: "Sylvain Lebresne (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12673491.1381524308778.59315.1381742384415@arcas>
In-Reply-To: <JIRA.12673491.1381524308778@arcas>
References: <JIRA.12673491.1381524308778@arcas>
Subject: [jira] [Commented] (CASSANDRA-6185) Can't update int column to blob
 type.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/CASSANDRA-6185?page=3Dcom.atlas=
sian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D=
13794007#comment-13794007 ]=20

Sylvain Lebresne commented on CASSANDRA-6185:
---------------------------------------------

bq. or is this actually a regression?

Kind of. In CASSANDRA-5882, we decided on purpose to stop allowing type cha=
nges that were not making sense. In doing so, we've been too restrictive, d=
isallowing some type changes that stricly speaking make sense, which you co=
uld say is a restriction (of CASSANDRA-5882).

I'll note that the patch really only change code related to altering type, =
which is hardly mission critical, so I don't think there is too much risk i=
n pushing it in 1.2. But personally I don't really care either way.


> Can't update int column to blob type.
> -------------------------------------
>
>                 Key: CASSANDRA-6185
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6185
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Nick Bailey
>            Assignee: Sylvain Lebresne
>            Priority: Minor
>             Fix For: 2.0.2
>
>         Attachments: 6185.txt
>
>
> Patch for dtests:
> {noformat}
> diff --git a/cql_tests.py b/cql_tests.py
> index 11461e4..405c998 100644
> --- a/cql_tests.py
> +++ b/cql_tests.py
> @@ -1547,35 +1547,35 @@ class TestCQL(Tester):
>              CREATE TABLE test (
>                  k text,
>                  c text,
> -                v text,
> +                v int,
>                  PRIMARY KEY (k, c)
>              )
>          """)
> -        req =3D "INSERT INTO test (k, c, v) VALUES ('%s', '%s', '%s')"
> +        req =3D "INSERT INTO test (k, c, v) VALUES ('%s', '%s', %d)"
>          # using utf8 character so that we can see the transition to Byte=
sType
> -        cursor.execute(req % ('=C9=B8', '=C9=B8', '=C9=B8'))
> +        cursor.execute(req % ('=C9=B8', '=C9=B8', 1))
>          cursor.execute("SELECT * FROM test")
>          cursor.execute("SELECT * FROM test")
>          res =3D cursor.fetchall()
> -        assert res =3D=3D [[u'=C9=B8', u'=C9=B8', u'=C9=B8']], res
> +        assert res =3D=3D [[u'=C9=B8', u'=C9=B8', 1]], res
>          cursor.execute("ALTER TABLE test ALTER v TYPE blob")
>          cursor.execute("SELECT * FROM test")
>          res =3D cursor.fetchall()
>          # the last should not be utf8 but a raw string
> -        assert res =3D=3D [[u'=C9=B8', u'=C9=B8', '=C9=B8']], res
> +        assert res =3D=3D [[u'=C9=B8', u'=C9=B8', '\x00\x00\x00\x01']], =
res
>          cursor.execute("ALTER TABLE test ALTER k TYPE blob")
>          cursor.execute("SELECT * FROM test")
>          res =3D cursor.fetchall()
> -        assert res =3D=3D [['=C9=B8', u'=C9=B8', '=C9=B8']], res
> +        assert res =3D=3D [['=C9=B8', u'=C9=B8', '\x00\x00\x00\x01']], r=
es
>          cursor.execute("ALTER TABLE test ALTER c TYPE blob")
>          cursor.execute("SELECT * FROM test")
>          res =3D cursor.fetchall()
> -        assert res =3D=3D [['=C9=B8', '=C9=B8', '=C9=B8']], res
> +        assert res =3D=3D [['=C9=B8', '=C9=B8', '\x00\x00\x00\x01']], re=
s
>      @since('1.2')
>      def composite_row_key_test(self):
> {noformat}


--
This message was sent by Atlassian JIRA
(v6.1#6144)