cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvain Lebresne (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-6233) Authentication is broken for the protocol v1 on C* 2.0
Date Sun, 27 Oct 2013 19:02:33 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13806425#comment-13806425
] 

Sylvain Lebresne commented on CASSANDRA-6233:
---------------------------------------------

Hum, I think I screwed up, didn't meant to commit it before the review. But well, I guess
it's done now :)

> Authentication is broken for the protocol v1 on C* 2.0
> ------------------------------------------------------
>
>                 Key: CASSANDRA-6233
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6233
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Sylvain Lebresne
>            Assignee: Sylvain Lebresne
>             Fix For: 2.0.2
>
>         Attachments: 6233.txt
>
>
> CASSANDRA-5664 simplified the decoding method of CredentialsMessage by using CBUtil.readStringMap
(instead of duplicating the code). Unfortunately, that latter method turns his keys to uppercase
(to provide some form of case insensitivity for keys), and in the case of CredentialsMessage
this breaks PasswordAuthenticator that expect lowercased keys (besides, it's a bad idea to
mess up with the case of the credentials map in general).
> Making CBUtil.readStringMap uppercase keys was probably a bad idea in the first place
(as nothing in the method name imply this), so attaching patch that remove this (and uppercase
keys specifically in StartupMessage where that was done on purpose).



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message