cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Ellis (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-5894) CQL-aware SSTableWriter
Date Fri, 25 Oct 2013 00:39:03 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-5894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13804858#comment-13804858
] 

Jonathan Ellis commented on CASSANDRA-5894:
-------------------------------------------

LGTM overall.

Nits:

Not a fan of the table of type correspondences; I see this getting out of date as we add types.
 Isn't there one for e.g. Java Driver docs we can put a link to instead?

For CqlOutputFormat we use a Map<column name, value> which seems a little better than
List<object> to me.  Specifically, if the loader is adding in data streamed from another
source, it won't have to buffer and re-order columns by name manually prior to addRow.

(I suppose we could have both, with the Map version turning it into a List automagically.)

> CQL-aware SSTableWriter
> -----------------------
>
>                 Key: CASSANDRA-5894
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5894
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Tools
>            Reporter: Jonathan Ellis
>            Assignee: Sylvain Lebresne
>            Priority: Minor
>             Fix For: 2.0.2
>
>         Attachments: 5894.txt, 5894-v2.txt
>
>
> SSTableSimple[Un]SortedWriter requires defining raw comparators and inserting raw data
cells.  We should create a CQL-aware alternative.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message