cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yuki Morishita (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-5871) Update nodetool to use o.a.c.metrics
Date Tue, 29 Oct 2013 21:23:25 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-5871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13808471#comment-13808471
] 

Yuki Morishita commented on CASSANDRA-5871:
-------------------------------------------

Lyuben,

Thanks for the patch.
Couple of things:

* You used StorageMetrics.exceptions.count() but it's always 0 since nodetool runs on separate
JVM.
* You can use local var 'cfname'  for cfstore.getColumnFamilyName() in printColumnFamilyStats
* Can you also substitute deprecated CFMBean metrics with new getColumnFamilyMetrics method?
There are couple more left inside  printColumnFamilyStats.


> Update nodetool to use o.a.c.metrics
> ------------------------------------
>
>                 Key: CASSANDRA-5871
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5871
>             Project: Cassandra
>          Issue Type: Task
>            Reporter: Yuki Morishita
>            Assignee: Lyuben Todorov
>            Priority: Minor
>             Fix For: 2.1
>
>         Attachments: 5871.patch
>
>
> Since C* 1.2, metrics are moved from *MBeans to own o.a.c.metrics package and are exposed
through metrics-core library.
> But nodetool is still using deprecated MBean metrics, so it is time to migrate to new
API.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message