cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dave Brosius (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-5862) Switch to adler checksum for sstables
Date Wed, 09 Oct 2013 02:24:43 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-5862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13789952#comment-13789952
] 

Dave Brosius commented on CASSANDRA-5862:
-----------------------------------------

I notice that aside from the switch to adler, the checksumming was switched from the uncompressed
buffer to the compressed buffer. Was this intended? If so CompressedSequentialWriter.resetAndTruncate
can remove the code that uncompresses the buffer, as it's not used.

> Switch to adler checksum for sstables
> -------------------------------------
>
>                 Key: CASSANDRA-5862
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5862
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Jonathan Ellis
>            Assignee: T Jake Luciani
>             Fix For: 2.0.1
>
>         Attachments: 5862.txt
>
>
> Adler is significantly faster than CRC32: http://java-performance.info/java-crc32-and-adler32/
> (Adler is weaker for short inputs, so we should leave the commitlog alone, as it checksums
each mutation individually.)



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message