cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "lantao yan (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-5078) save compaction merge counts in a system table
Date Thu, 03 Oct 2013 16:16:42 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-5078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13785079#comment-13785079
] 

lantao yan edited comment on CASSANDRA-5078 at 10/3/13 4:16 PM:
----------------------------------------------------------------

. 


was (Author: yanlantao):
@Yuki Morishita, I checked that code, I think I was right about each thread will run against
one column family store.
so two threads are working on the same column family with the same timestamp will never happen.

CompactionTask.java
    protected void runWith(File sstableDirectory) throws Exception // it is running against
a sstableDirectory, which is a cfs directory I guess.

If given two compaction threads can work on the same column family store(directory, and files),
we may have risk condition.
[~jbellis], correct me if I am wrong.

> save compaction merge counts in a system table
> ----------------------------------------------
>
>                 Key: CASSANDRA-5078
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5078
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Matthew F. Dennis
>            Assignee: lantao yan
>            Priority: Minor
>              Labels: lhf
>         Attachments: 5078-v3.txt, 5078-v4.txt, patch1.patch
>
>
> we should save the compaction merge stats from CASSANDRA-4894 in the system table and
probably expose them via JMX (and nodetool)



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message