cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tyler Hobbs (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-4430) optional pluggable o.a.c.metrics reporters
Date Tue, 01 Oct 2013 17:23:28 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-4430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13783147#comment-13783147
] 

Tyler Hobbs commented on CASSANDRA-4430:
----------------------------------------

Looks good except for a couple of nitpicks:
* Check that {{metricsReporterConfigFile}} isn't {{null}} before logging and attempting to
load the file in CassandraDaemon
* There are some blank lines at the end of the example config file

> optional pluggable o.a.c.metrics reporters
> ------------------------------------------
>
>                 Key: CASSANDRA-4430
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4430
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Chris Burroughs
>            Assignee: Chris Burroughs
>            Priority: Minor
>             Fix For: 2.1
>
>         Attachments: 4430-2.0.txt, 4430-trunk.txt, cassandra-ganglia-example.png
>
>
> CASSANDRA-4009  expanded the use of the metrics library which has a set of reporter modules
http://metrics.codahale.com/manual/core/#reporters  You can report to flat files, ganglia,
spit everything over http, etc.  The next step is a mechanism for using those reporters with
 o.a.c.metrics.  To avoid bundling everything I suggest following the mx4j approach of "enable
only if on classpath coupled with a reporter configuration file.
> Strawman file:
> {noformat}
> console:
>   time: 1
>   timeunit: "seconds"
> csv:
>  - time: 1
>    timeunit: minutes
>    file: foo.csv
>  - time: 10
>    timeunit: seconds
>     file: bar.csv
> ganglia:
>  - time: 30
>    timunit: seconds
>    host: server-1
>    port: 8649
>  - time: 30
>    timunit: seconds
>    host: server-2
>    port: 8649
> {noformat}
>  



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message