Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8767210181 for ; Mon, 23 Sep 2013 17:53:16 +0000 (UTC) Received: (qmail 10021 invoked by uid 500); 23 Sep 2013 17:53:11 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 9827 invoked by uid 500); 23 Sep 2013 17:53:07 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 9711 invoked by uid 99); 23 Sep 2013 17:53:04 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Sep 2013 17:53:04 +0000 Date: Mon, 23 Sep 2013 17:53:04 +0000 (UTC) From: "Jeremiah Jordan (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-6042) Add WARN when there are a lot of tombstones in a query MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-6042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13774780#comment-13774780 ] Jeremiah Jordan commented on CASSANDRA-6042: -------------------------------------------- [~jbellis] beat me to it, but LGTM. +1 :). > Add WARN when there are a lot of tombstones in a query > ------------------------------------------------------ > > Key: CASSANDRA-6042 > URL: https://issues.apache.org/jira/browse/CASSANDRA-6042 > Project: Cassandra > Issue Type: Improvement > Reporter: Jeremiah Jordan > Assignee: Russell Alexander Spitzer > Priority: Minor > Fix For: 1.2.11, 2.0.2 > > Attachments: 0001-JMX-and-Debug-Messages-for-Max-Tombstone-Scans.patch, 0002-JMX-and-Debug-Messages-for-Max-Tombstone-Scans.patch > > > Now that we count the number of tombstones hit (so it can go in tracing), can we pick some threshold (or make it configurable with 0 being don't warn), and spit out a warning saying "Just went through 10000 tombstones in partition XYZ". > Right now if you are having GC problems because some row got a bunch of tombstones, you can turn on server side tracing, and hope the bad query gets in there, or you can keep making heap dumps, dig through them, and hope you catch the query in there. > I have seen code problems at multiple places causing this same issue (some code causing way more tombstones than it should, for just one row). And it is a PITA+Luck to debug it right now. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira