Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Fri, 20 Sep 2013 22:36:53 +0000 (UTC)
From: "Jonathan Ellis (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12609295.1348687560071.171653.1379716613070@arcas>
In-Reply-To: <JIRA.12609295.1348687560071@arcas>
References: <JIRA.12609295.1348687560071@arcas>
Subject: [jira] [Commented] (CASSANDRA-4725) VERSION string conflict in C++
 programs
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CASSANDRA-4725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13773545#comment-13773545 ] 

Jonathan Ellis commented on CASSANDRA-4725:
-------------------------------------------

Doesn't seem like it's worth breaking existing clients to fix this; new clients should use native protocol instead.
                
> VERSION string conflict in C++ programs
> ---------------------------------------
>
>                 Key: CASSANDRA-4725
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4725
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: Jochen Topf
>
> In cassandra.thrift there is a definition like this:
> const string VERSION = "19.32.0"
> When building the C++ code with thrift, this leads to a file cassandra_constants.h and cassandra_constants.cpp which contain the following lines:
> cassandra_constants.cpp:  VERSION = "19.32.0";
> cassandra_constants.h:  std::string VERSION;
> Unfortunately "VERSION" is all uppercase, this is generally used in macros in C++ and the macro "VERSION" is used in many programs for instance when using GNU autoconf. If there is a VERSION macro it will be expanded and those lines will break.
> Maybe we can rename this to "Version" or so?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira