cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yuki Morishita (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-6086) Node refuses to start with exception in ColumnFamilyStore.removeUnfinishedCompactionLeftovers when find that some to be removed files are already removed
Date Tue, 24 Sep 2013 15:34:04 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-6086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776390#comment-13776390
] 

Yuki Morishita edited comment on CASSANDRA-6086 at 9/24/13 3:32 PM:
--------------------------------------------------------------------

The primary reason we have removeUnfinishedCompacitonLeftovers check is to not overcount counters
stored.
If we do not stop at the original exception, then we will have both compacted SSTables and
leftovers which may produce unexpected counter value.

Though we have the report that "this happens"(CASSANDRA-6008), we should fix somehow.
Maybe we can consider compaction is finished even if we have entry in compactions_in_progress
but some or all of the input SSTables are missing.
                
      was (Author: yukim):
    The primary reason we have removeUnfinishedCompacitonLeftovers check is to not overcount
counters stored.
If we do not stop at the original exception, then we will have both compacted SSTables and
leftovers which may produce unexpected counter value.
Though we have the report that "this happens"(CASSANDRA-6008), we should fix somehow.

Maybe we consider compaction is finished even if we have entry in compactions_in_progress
but some or all of the input SSTables are missing.
                  
> Node refuses to start with exception in ColumnFamilyStore.removeUnfinishedCompactionLeftovers
when find that some to be removed files are already removed
> ---------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-6086
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6086
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Oleg Anastasyev
>         Attachments: removeUnfinishedCompactionLeftovers.txt
>
>
> Node refuses to start with
> {code}
> Caused by: java.lang.IllegalStateException: Unfinished compactions reference missing
sstables. This should never happen since compactions are marked finished before we start removing
the old sstables.
>       at org.apache.cassandra.db.ColumnFamilyStore.removeUnfinishedCompactionLeftovers(ColumnFamilyStore.java:544)
>       at org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:262)
> {code}
> IMO, there is no reason to refuse to start discivering files that must be removed are
already removed. It looks like pure bug diagnostic code and mean nothing to operator (nor
he can do anything about this).
> Replaced throw of excepion with dump of diagnostic warning and continue startup.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message