cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brandon Williams (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-6036) When SStableloader exits, allow for a non-zero exit code if an exception is encounterd
Date Mon, 16 Sep 2013 22:43:57 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-6036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13768890#comment-13768890
] 

Brandon Williams commented on CASSANDRA-6036:
---------------------------------------------

what version was this against? I ask because we have this:

{noformat}
        catch (Exception e)
        {
            System.err.println(e.getMessage());
            if (options.debug)
                e.printStackTrace(System.err);
            System.exit(1);
        }
{noformat}
                
> When SStableloader exits, allow for a non-zero exit code if an exception is encounterd
> --------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-6036
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6036
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Tools
>            Reporter: Laura Adney
>
> Request from customer to have sstableloader exit with non-zero exit code when an exception
is encountered.
> Customer reports:1379107056.40 ERROR [Thread-108] 2013-09-13 17:17:36,344 CassandraDaemon.java
(line 192) Exception in thread Thread[Thread-108,5,main]
> 1379107056.40 java.lang.AssertionError
> 1379107056.40 	at org.apache.cassandra.streaming.StreamInSession.closeIfFinished(StreamInSession.java:168)
> 1379107056.40 	at org.apache.cassandra.streaming.IncomingStreamReader.read(IncomingStreamReader.java:138)
> 1379107056.40 	at org.apache.cassandra.net.IncomingTcpConnection.stream(IncomingTcpConnection.java:238)
> 1379107056.40 	at org.apache.cassandra.net.IncomingTcpConnection.handleStream(IncomingTcpConnection.java:178)
> 1379107056.40 	at org.apache.cassandra.net.IncomingTcpConnection.run(IncomingTcpConnection.java:78)
> 1379107056.40 ERROR [Thread-108] 17:17:36,344 Exception in thread Thread[Thread-108,5,main]
> 1379107056.40 java.lang.AssertionError
> 1379107056.40 	at org.apache.cassandra.streaming.StreamInSession.closeIfFinished(StreamInSession.java:168)
> 1379107056.40 	at org.apache.cassandra.streaming.IncomingStreamReader.read(IncomingStreamReader.java:138)
> 1379107056.40 	at org.apache.cassandra.net.IncomingTcpConnection.stream(IncomingTcpConnection.java:238)
> 1379107056.40 	at org.apache.cassandra.net.IncomingTcpConnection.handleStream(IncomingTcpConnection.java:178)
> 1379107056.40 	at org.apache.cassandra.net.IncomingTcpConnection.run(IncomingTcpConnection.java:78)
> And finally: sstableloader exits 0 in this condition, as opposed to non-zero, so our
tools blindly pass over this and don't realize that the import failed. That's pretty bad,
too.
> zd6699

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message