cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Ellis (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-5931) Fix periodic flushing when encountering an empty memtable
Date Fri, 23 Aug 2013 22:25:53 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-5931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13749084#comment-13749084
] 

Jonathan Ellis commented on CASSANDRA-5931:
-------------------------------------------

+1

Nit: it's probably time to add javadoc with @returns to forceFlush to help prevent this confusion
                
> Fix periodic flushing when encountering an empty memtable
> ---------------------------------------------------------
>
>                 Key: CASSANDRA-5931
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5931
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Aleksey Yeschenko
>            Assignee: Aleksey Yeschenko
>            Priority: Minor
>             Fix For: 2.0
>
>         Attachments: 5931.txt
>
>
> CASSANDRA-5241 broke it by making forceFlush() always return a valid future, never a
null, and CASSANDRA-4237 was relying on that null check to determine cleanliness.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message