cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nate McCall (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-5826) Fix trigger directory detection code
Date Fri, 02 Aug 2013 18:31:49 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-5826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13727929#comment-13727929
] 

Nate McCall commented on CASSANDRA-5826:
----------------------------------------

bq. What would a Real Java Programmer do here Nate McCall?

Awww shucks. Capitalized and everything!

I would expect that it is on me to put my own dependencies in the existing "lib" directory.
As a principle of least surprise: web containers, such as Tomcat, have a top level lib directory
where you can put shared dependencies (http://tomcat.apache.org/tomcat-7.0-doc/appdev/deployment.html#Shared_Library_Files).


This has the benefit of not requiring modification of cassandra.in.sh or similar init scripts
already in the wild. 

As long as we are not trying to isolate classloaders or anything (not a bad idea for triggers
in the future) there is no need technically or conventionally to have user binaries somewhere
else. If folks want something different, they can hack the scripts to noodle the classpath
to their hearts content. 
                
> Fix trigger directory detection code
> ------------------------------------
>
>                 Key: CASSANDRA-5826
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5826
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.0 beta 2
>         Environment: OS X
>            Reporter: Aleksey Yeschenko
>            Assignee: Vijay
>              Labels: triggers
>             Fix For: 2.0 rc1
>
>         Attachments: 0001-5826.patch
>
>
> At least when building from source, Cassandra determines the trigger directory wrong.
C* calculates the trigger directory as 'build/triggers' instead of 'triggers'.
> FBUtilities.cassandraHomeDir() is to blame, and should be replaced with something more
robust.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message