Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Thu, 11 Jul 2013 23:11:48 +0000 (UTC)
From: "Nick Bailey (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12656079.1372873353514.36505.1373584308819@arcas>
In-Reply-To: <JIRA.12656079.1372873353514@arcas>
References: <JIRA.12656079.1372873353514@arcas>
Subject: [jira] [Commented] (CASSANDRA-5722) Cleanup should skip sstables
 that don't contain data outside a nodes ranges
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CASSANDRA-5722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13706414#comment-13706414 ] 

Nick Bailey commented on CASSANDRA-5722:
----------------------------------------

After thinking about this a bit more, this is going to be pretty useless with vnodes isn't it? Each sstable is going to contain keys from all over the ring so this probably won't be able to skip any.

I guess there are enough people not on vnodes it could be worth it still though.
                
> Cleanup should skip sstables that don't contain data outside a nodes ranges
> ---------------------------------------------------------------------------
>
>                 Key: CASSANDRA-5722
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5722
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Nick Bailey
>            Assignee: Tyler Hobbs
>             Fix For: 2.0.1
>
>
> Right now cleanup is optimized to simply delete sstables that *only* contain data that doesn't belong on the node, for all other sstables though, it will read them, check each row, and write out new sstables.
> Cleanup could be optimized to look at an sstable and determine that all data within the sstable does belong on a node, and therefore skip re-writing that sstable. This would make cleanup essentially a noop in the case where all data on a node belongs on that node.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira