Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Tue, 2 Jul 2013 17:09:21 +0000 (UTC)
From: "Jason Brown (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12655808.1372784664950.199777.1372784961191@arcas>
In-Reply-To: <JIRA.12655808.1372784664950@arcas>
References: <JIRA.12655808.1372784664950@arcas>
Subject: [jira] [Updated] (CASSANDRA-5719) Expire entries out of
 ThriftSessionManager
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/CASSANDRA-5719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason Brown updated CASSANDRA-5719:
-----------------------------------

    Attachment: 5719-v1.patch

v1 patch replaces the TSM's Map with guava's Cache object. The guava Cache allows us to expire items out of the cache based on lastAccess time (if it's exceeded some threshold, drop the entry). I selected some basic defaults for the cache (150,000 max entries, and 4 hour time limit for last usage), but I'm open to adjusting those values.
                
> Expire entries out of ThriftSessionManager
> ------------------------------------------
>
>                 Key: CASSANDRA-5719
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5719
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.2.0
>            Reporter: Jason Brown
>            Assignee: Jason Brown
>            Priority: Minor
>              Labels: cache, thrift
>             Fix For: 1.2.7, 2.0 beta 1
>
>         Attachments: 5719-v1.patch
>
>
> TSM maintains a map of SocketAddress (IpAddr, and the ephemeral port) to ClientState. If the connection goes away, for whatever reason, entries are not removed from the map. In most cases this is a tiny leakage. However, at Netflix, we auto-scale services up and down everyday, sometimes with client instance lifetimes of around 36 hours. These clusters can add hundreds of servers at peak time, and indescriminantly terminate them at the trough. The net effect for cassandra is that we'll leave thousands of dead entries in the TSM.activeSocketSessions map. When I looked at an instance in a well-used cluster yesterday, there were almost 400,000 entries in the map.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira