cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Brown (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-5823) nodetool history logging
Date Tue, 30 Jul 2013 14:03:48 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-5823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13723873#comment-13723873
] 

Jason Brown edited comment on CASSANDRA-5823 at 7/30/13 2:02 PM:
-----------------------------------------------------------------

v2 centralizes the placement of c* history files into \~/.cassandra. This means cqlsh, cli,
and nodetool all write to the new directory. Two of the files were renamed slightly for clarity.
For cli (history and assumptions) and cqlsh (cqlshrc and history), I updated the code to move
any older files into the new \~/.cassandra dir, and cleaned up any leftovers (\~/.cassandra-cli).
I added a centralized method for getting the history dir location: FBUtilities.getHistoryDirectory().
I couldn't find a better class for that method, but I'm happy to move it elsewhere.

I didn't address the \~/.cassandra.in.sh yet (if we want), and the try-with-resources recommendation
(in NodeCmd) will be applied to trunk.
                
      was (Author: jasobrown):
    v2 centralizes the placement of c* history files into ~/.cassandra. This means cqlsh,
cli, and nodetool all write to the new directory. Two of the files were renamed slightly for
clarity. For cli (history and assumptions) and cqlsh (cqlshrc and history), I updated the
code to move any older files into the new ~/.cassandra dir, and cleaned up any leftovers (~/.cassandra-cli).
I added a centralized method for getting the history dir location: FBUtilities.getHistoryDirectory().
I couldn't find a better class for that method, but I'm happy to move it elsewhere.

I didn't address the ~/.cassandra.in.sh yet (if we want), and the try-with-resources recommendation
(in NodeCmd) will be applied to trunk.
                  
> nodetool history logging
> ------------------------
>
>                 Key: CASSANDRA-5823
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5823
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Tools
>            Reporter: Jason Brown
>            Assignee: Jason Brown
>            Priority: Minor
>             Fix For: 1.2.8, 2.0 rc1
>
>         Attachments: 5823-v1.patch, 5823-v2.patch
>
>
> Capture the commands and time executed from nodetool into a log file, similar to the
cli.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message