cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tyler Hobbs (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-5722) Cleanup should skip sstables that don't contain data outside a nodes ranges
Date Tue, 16 Jul 2013 19:50:48 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-5722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13710141#comment-13710141
] 

Tyler Hobbs commented on CASSANDRA-5722:
----------------------------------------

bq. However, now that I think about it, I believe your change to firstKeyBeyond() may mishandle
one case. It needs to check the first key of the next range. Otherwise, if the token falls
at the end of the index range (past the last indexed key), it will improperly return null,
indicating no keys beyond that. I'll add a test to verify and comment if so.

I was incorrect here, the simplification is good.
                
> Cleanup should skip sstables that don't contain data outside a nodes ranges
> ---------------------------------------------------------------------------
>
>                 Key: CASSANDRA-5722
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5722
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Nick Bailey
>            Assignee: Tyler Hobbs
>             Fix For: 2.0.1
>
>         Attachments: 0001-Skip-cleanup-when-unneeded.patch
>
>
> Right now cleanup is optimized to simply delete sstables that *only* contain data that
doesn't belong on the node, for all other sstables though, it will read them, check each row,
and write out new sstables.
> Cleanup could be optimized to look at an sstable and determine that all data within the
sstable does belong on a node, and therefore skip re-writing that sstable. This would make
cleanup essentially a noop in the case where all data on a node belongs on that node.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message