cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vijay (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-5681) Refactor IESCS in Snitches
Date Sat, 06 Jul 2013 23:05:49 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-5681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13701442#comment-13701442
] 

Vijay edited comment on CASSANDRA-5681 at 7/6/13 11:04 PM:
-----------------------------------------------------------

wont the following break the reconnects during the upgrade? (since the reconnect will happen
only if the remote version is current version)

ReconnectableSnitchHelper.reconnect(InetAddress publicAddress, InetAddress localAddress)
{code}
if (snitch.getDatacenter(publicAddress).equals(localDc)
                && MessagingService.instance().getVersion(publicAddress) == MessagingService.current_version
                && !MessagingService.instance().getConnectionPool(publicAddress).endPoint().equals(localAddress))
{code}
                
      was (Author: vijay2win@yahoo.com):
    wont the following break the reconnects during the upgrade?

ReconnectableSnitchHelper.reconnect(InetAddress publicAddress, InetAddress localAddress)
{code}
if (snitch.getDatacenter(publicAddress).equals(localDc)
                && MessagingService.instance().getVersion(publicAddress) == MessagingService.current_version
                && !MessagingService.instance().getConnectionPool(publicAddress).endPoint().equals(localAddress))
{code}
                  
> Refactor IESCS in Snitches
> --------------------------
>
>                 Key: CASSANDRA-5681
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5681
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.2.5
>            Reporter: Jason Brown
>            Assignee: Jason Brown
>            Priority: Minor
>              Labels: snitch
>             Fix For: 1.2.6, 2.0 beta 1
>
>         Attachments: 5681-v1.diff, 5681-v2_YFNTS.diff
>
>
> Reduce/refactor duplicated IESCS implementations in Ec2MRS, GPFS, and YPNTS.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message