cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvain Lebresne (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-5542) BulkLoader is broken in trunk
Date Tue, 16 Jul 2013 07:14:49 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-5542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13709560#comment-13709560
] 

Sylvain Lebresne commented on CASSANDRA-5542:
---------------------------------------------

Looks mostly good. A couple of minor remarks/nits:
 * In ConnectionHandler, initiateOnReceivingSide and the pair attach(Incoming/Outgoing)Socket
are basically duplicates. We should keep only one of them.
 * We use to call the StreamSession.start(Socket, ...) (the one on the receiving side) on
the streamExecutor because it was creating a connection (and was thus blocking on I/O). Since
it's not the case anymore, it's probably overkill. So we could ditch that whole start function
and do the attachSocket in SRF.initReceivingSide, which would improve the symmetry of that
function.
 * Does separating initiated and receiving stream in StreamManager really buys us anything?
(outside slightly complicating things)
 * On failure (StreamSession.onError), we could (and probably should) send a message as long
as the outgoing connection is opened (even if the incoming one is broken), so the current
isConnected() is possibly a bit restrictive.
 * For consistency sake, can't we rename forOutput to isOutgoing everywhere, and same for
isFirst in ConnectionHandler.sendInitMessage.
 * The comment on StreamInitMessage.isForOutgoing is outdated (talk of ACK, INIT_ACK)
 * The comment on on top StreamSession still talks of InitCompleteMessage.
 * The comment in IncomingStreamingSession still mentions INIT_ACK

                
> BulkLoader is broken in trunk
> -----------------------------
>
>                 Key: CASSANDRA-5542
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5542
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 2.0 beta 1
>            Reporter: Yuki Morishita
>            Assignee: Yuki Morishita
>             Fix For: 2.0
>
>         Attachments: 0001-change-streaming-procedure.patch, 0002-make-BulkLoader-work-with-SSTableReader.patch,
0003-update-for-post-CASSANDRA-5171.patch, 5542-fix-NPE.txt, 5542.txt
>
>
> After CASSANDRA-5015 and CASSANDRA-5521, we need CFMetaData to open SSTable(Reader),
especially to get bloom_filter_fp_chance and index_interval.
> When using bulkloader, CFMetaData is not available, so we cannot open SSTable to be streamed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message