Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E8D7E108A8 for ; Thu, 27 Jun 2013 04:03:25 +0000 (UTC) Received: (qmail 64624 invoked by uid 500); 27 Jun 2013 04:03:25 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 64366 invoked by uid 500); 27 Jun 2013 04:03:21 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 64048 invoked by uid 99); 27 Jun 2013 04:03:20 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Jun 2013 04:03:20 +0000 Date: Thu, 27 Jun 2013 04:03:20 +0000 (UTC) From: "Pavel Yaskevich (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-5661) Discard pooled readers for cold data MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-5661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13694466#comment-13694466 ] Pavel Yaskevich commented on CASSANDRA-5661: -------------------------------------------- In other words, my initial idea didn't take into account leveled compaction, it was simple - by paying overall small memory price (one chunk size or less depending on size of file) per 1GB we can minimize GC work, memory allocation and number of syscalls per read. With leveled compaction that strategy doesn't work as price per 1 GB is pretty big as most of the files are very small which increases allocation rate to cache and GC activity by very frequent compactions. > Discard pooled readers for cold data > ------------------------------------ > > Key: CASSANDRA-5661 > URL: https://issues.apache.org/jira/browse/CASSANDRA-5661 > Project: Cassandra > Issue Type: Bug > Components: Core > Affects Versions: 1.2.1 > Reporter: Jonathan Ellis > Assignee: Pavel Yaskevich > Fix For: 1.2.7 > > Attachments: DominatorTree.png, Histogram.png > > > Reader pooling was introduced in CASSANDRA-4942 but pooled RandomAccessReaders are never cleaned up until the SSTableReader is closed. So memory use is "the worst case simultaneous RAR we had open for this file, forever." > We should introduce a global limit on how much memory to use for RAR, and evict old ones. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira