Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Sun, 16 Jun 2013 19:59:20 +0000 (UTC)
From: "Aleksey Yeschenko (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12648170.1368793488790.122546.1371412760541@arcas>
In-Reply-To: <JIRA.12648170.1368793488790@arcas>
References: <JIRA.12648170.1368793488790@arcas>
Subject: [jira] [Comment Edited] (CASSANDRA-5576) CREATE/DROP TRIGGER in CQL
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CASSANDRA-5576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13684739#comment-13684739 ] 

Aleksey Yeschenko edited comment on CASSANDRA-5576 at 6/16/13 7:57 PM:
-----------------------------------------------------------------------

bq. As a user i use thrift for various reasons like performance and i am not sure if i would switch that soon, specially with the cross platforms we have to deal with.

You'd only have to use CQL3 for DROP and CREATE TRIGGER (via thfit.execute_cql3_query()) and ignore it otherwise. Speed not affected (unless you are talking about the speed of creating a trigger (: ). Though I can see some value of being able to modify triggers via thrift.system_update_column_family() if one has no CQL3 tables at all and doesn't want to bother with it, ever.

Can you make it map<string, map<string, string>> (index name -> index options, including class) then? So that once we add parametrization support, thrift wouldn't have to change at all?

Other than this, everything looks fine to me.

(tiny nit: FBUtilities.fromJsonListObject() is now unused and can be removed)
                
      was (Author: iamaleksey):
    bq. As a user i use thrift for various reasons like performance and i am not sure if i would switch that soon, specially with the cross platforms we have to deal with.

You'd only have to use CQL3 for DROP and CREATE TRIGGER (via thfit.execute_cql3_query()) and ignore it otherwise. Speed not affected (unless you are talking about the speed of creating a trigger (: ). Though I can see some value of being able to modify triggers via thrift.system_update_column_family() if one has no CQL3 tables at all and doesn't want to bother with it, ever.

Can you make it list<map<string, map<string, string>>> (list(index name -> index options, including class)) then? So that once we add parametrization support, thrift wouldn't have to change at all?

Other than this, everything looks fine to me.

(tiny nit: FBUtilities.fromJsonListObject() is now unused and can be removed)
                  
> CREATE/DROP TRIGGER in CQL
> --------------------------
>
>                 Key: CASSANDRA-5576
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5576
>             Project: Cassandra
>          Issue Type: Bug
>          Components: API, Core
>            Reporter: Jonathan Ellis
>            Assignee: Vijay
>             Fix For: 2.0
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira